vuejs / eslint-config-airbnb

ESLint Shareable Configs for Airbnb JavaScript Style Guide in Vue.js Projects
MIT License
72 stars 20 forks source link

Upgrade @eslint-typescript to v6 #58

Closed frsimond closed 10 months ago

frsimond commented 1 year ago

If I use this package with the latest typescript and vue versions (ie: 5.1.x and 3.3.x) I get this message.

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.1.0

YOUR TYPESCRIPT VERSION: 5.1.6

Please only submit bug reports when using the officially supported version.

But vue's repo's packages.json do not mention any limitations regarding the typescript version to be used with.

Three weeks ago, typescript-eslint released the v6.0.0 and eslint-config-airbnb-typescript followed right after with the v17.1.0.

Unlike what eslint-config-airbnb-typescript did and because of @rushstack/eslint-patch, I personnally think this package should target the latest version only. But if so rules breaking changes should be mentionned in the release and therefore it might need a Major version bump (ie: v8.0.0).

What do you think @sodatea ?

PurpleTape commented 1 year ago

Any updates? 🥺🥺🥺

frsimond commented 1 year ago

@PurpleTape I've tried to make a nice PR for this. But I am affraid to make opinionated decisions and I am really short on time for the moment. I would rather have @sodatea or an regular vue maintener handle this :)

undergroundwires commented 1 year ago

This is blocking upgrading following dependencies for me:

Can we please take a look at this @sodatea ❤️? Your work is highly appreciated and it's very nice to provide this package to community. But it has gotten so outdated that it has become a blocker for our modern TypeScript development. I think it deserves some attention. Quoting Vue.js homepage:

Vue is written in TypeScript itself and provides first-class TypeScript support.

everyx commented 1 year ago

There is a workaround if you're using PNPM, you can use PNPM overrides to force using version 6.x: Add to your package.json:

 "pnpm": {
    "overrides": {
      "@typescript-eslint/parser": "6.9.0"
    }
  }

Then run pnpm install again