vuejs / eslint-config-typescript

ESLint configuration for Vue 3 + TypeScript projects
MIT License
128 stars 30 forks source link

Support additional typescript-eslint configs #73

Closed rijenkii closed 1 month ago

rijenkii commented 7 months ago

https://typescript-eslint.io/users/configs#recommended-configurations:

Currently it seems that only eslint-recommended and recommended are provided.

bmulholland commented 2 weeks ago

@haoqunjiang This was closed by #81, but that PR notes "I'm afraid I can't get the *-type-checked configurations right on the first try; I'm not sure about the performance in large projects either"

I spent a while trying to get this working and was confused by the error I got: Cannot read properties of undefined (reading 'files')

I guess this didn't actually make it in, and should be re-opened?

bmulholland commented 2 weeks ago

Ah but this is a dupe of the older https://github.com/vuejs/eslint-config-typescript/issues/67, right?

haoqunjiang commented 2 weeks ago

I spent a while trying to get this working and was confused by the error I got: Cannot read properties of undefined (reading 'files')

You might have accidentally used the kebab-case names instead of camelCase. It was an unfortunate oversight when I implemented this feature, but I can't change that now due to semver constraints, and supporting both cases would mess up the TypeScript suggestions. In v14.1.2 I added more friendly error messages for such errors. Could you try it out?

bmulholland commented 2 weeks ago

@haoqunjiang Ah nice. Yes, that was it. I upgraded and tried again; the error message appeared as expected and would have saved me time. Cool, all good then. Thank you!