vuejs / eslint-plugin-vue

Official ESLint plugin for Vue.js
https://eslint.vuejs.org/
MIT License
4.47k stars 667 forks source link

Fix Linter type import in index.d.ts #2572

Closed ocavue closed 1 month ago

ocavue commented 1 month ago

Thanks for adding TypeScript declarations in the latest v9.29.0.

I found an issue when using the new declaration. In the lib/index.d.ts, the Linter namespace is pointing to typings/eslint/index.d.ts. However, typings/ is not included in the final NPM package, therefore the declarations in index.d.ts is not working.

This issue can be fixed by adding a single line import type { Linter } from 'eslint' as shown in this PR.

Other code-styling changes included in this PR are made by Prettier based on eslint-plugin-vue's Prettier config.


Just FYI, the latest eslint has already includes TypeScript declarations, which means you don't need @types/eslint and perhaps also typings/eslint/index.d.ts anymore once eslint-plugin-vue updated to the latest version of eslint (currently eslint-plugin-vue is still using eslint@8).