search

vuejs / language-tools

⚡ High-performance Vue language tooling based-on Volar.js
https://marketplace.visualstudio.com/items?itemName=Vue.volar
MIT License
5.55k stars 373 forks source link

fix(tsc): log catched errors to console #4451

Closed mik3ybark3r closed 2 weeks ago

mik3ybark3r commented 2 weeks ago

This prevents that the output of a successful vue-tsc run looks the same like one finished with an unexpected error.

so1ve commented 2 weeks ago

What kind of error do you meet?

mik3ybark3r commented 2 weeks ago

In my case vue-tsc did not show any typescript errors when running with typescript version 5.1.6. I found the solution with the help of that issue: https://github.com/vuejs/language-tools/issues/4099 What frustrated me the most was that the following error was just catched without any output to the terminal:

ReferenceError: ScriptKind is not defined
    at eval (eval at get (/app/frontend/node_modules/typescript/lib/tsc.js:113647:179), <anonymous>:1:1)
    at Object.get (/app/frontend/node_modules/typescript/lib/tsc.js:113647:179)
    at Object.getServiceScript (/app/frontend/node_modules/@vue/language-core/lib/languageModule.js:155:46)
    at Object.fileExists (/app/frontend/node_modules/@volar/typescript/lib/resolveModuleName.js:26:105)
    at tryFileLookup (/app/frontend/node_modules/typescript/lib/tsc.js:37807:20)
    at tryFile (/app/frontend/node_modules/typescript/lib/tsc.js:37797:12)
    at tryExtension (/app/frontend/node_modules/typescript/lib/tsc.js:37790:18)
    at tryAddingExtensions (/app/frontend/node_modules/typescript/lib/tsc.js:37787:107)
    at loadModuleFromFileNoImplicitExtensions (/app/frontend/node_modules/typescript/lib/tsc.js:37747:10)
    at loadModuleFromFile (/app/frontend/node_modules/typescript/lib/tsc.js:37723:40)

The result was that we had some unknown typescript errors in the project because we weren't aware that vue-tsc is not working properly.

johnsoncodehk commented 2 weeks ago

Thanks!