vue component imports from node_modules are not being resolved

brc-dd commented 3 months ago

Vue - Official extension or vue-tsc version

2.0.28

VSCode version

1.92.0-insider (22e3447)

Vue version

3.4.33

TypeScript version

5.5.4

System Info

System:
    OS: macOS 14.5
    CPU: (10) arm64 Apple M2 Pro
    Memory: 512.38 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.2.0 - ~/.local/state/fnm_multishells/86941_1721795272757/bin/node
    Yarn: 1.22.22 - ~/.local/state/fnm_multishells/86941_1721795272757/bin/yarn
    npm: 10.7.0 - ~/.local/state/fnm_multishells/86941_1721795272757/bin/npm
    pnpm: 9.6.0 - ~/.local/state/fnm_multishells/86941_1721795272757/bin/pnpm
    bun: 1.1.17 - /opt/homebrew/bin/bun
  Browsers:
    Safari: 17.5
    Safari Technology Preview: 18.0

Steps to reproduce

Clone https://github.com/brc-dd/volar-component-resolution-bug
Install deps - pnpm i
Open Foo.vue to see errors:

What is expected?

No error and intellisense on component props to work.

What is actually happening?

Getting ts-plugin 2307 error.

Link to minimal reproduction

https://github.com/brc-dd/volar-component-resolution-bug

Any additional comments?

going through older issues here, I found https://github.com/vuejs/language-tools/issues/4019#issuecomment-2228416473 and it seems that it's now happening without aliases too and as that comment mentions, this doesn't happen when vue.server.hybridMode is set to typeScriptPluginOnly or false (np: the types of this property are wrong in manifest)
this is working fine with extension version 2.0.26 and with vue-tsc --noEmit

davidmatter commented 3 months ago

Confirmed, used to behave differently in 2.0.22

davidmatter commented 2 months ago

You can mitigate this by adding node_modules/vitepress/**/* to tsconfig/include.

vuejs / language-tools

vue component imports from node_modules are not being resolved #4611