vuejs / language-tools

⚡ High-performance Vue language tooling based-on Volar.js
https://marketplace.visualstudio.com/items?itemName=Vue.volar
MIT License
5.87k stars 400 forks source link

feat(language-service): add style scoped and module completion #4705

Closed runyasak closed 2 months ago

runyasak commented 3 months ago

Updated

Overview

I've added the scoped and module attributes to style completion items. Now, when we type style in completion, scoped and module are available as options.

Screenshots

https://github.com/user-attachments/assets/208847d7-e9f9-4c82-a893-91a52ee4caf2


This is my first PR. If you have any feedback or suggestions, please do not hesitate to let me know.

KazariEX commented 3 months ago

I think there is no need to extract languages to the top level, as it might be obtained from provider in the future. #4645

What about module?

runyasak commented 3 months ago

I think there is no need to extract languages to the top level, as it might be obtained from provider in the future. #4645

What about module?

Hi @KazariEX, I apologize for not seeing your PR earlier. Are you referring to CSS Modules? If no one is assigned to this feature, may I contribute to it? Should I create a new PR or update this one?

KazariEX commented 3 months ago

Just update directly, I think they belong to the same feature.

runyasak commented 3 months ago

@KazariEX I've updated my PR to module. Please review my code again.

KazariEX commented 3 months ago

Sorry I didn't mean replacement but both scoped and module.

runyasak commented 3 months ago

Sorry I didn't mean replacement but both scoped and module.

No problem. I will update now.

runyasak commented 3 months ago

@KazariEX I've updated my PR with attr as your suggestion. Please review my PR again.

pkg-pr-new[bot] commented 2 months ago

commit: 686384a

vue-component-meta

``` pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4705 ```

vue-component-type-helpers

``` pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4705 ```

@vue/language-core

``` pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4705 ```

@vue/language-plugin-pug

``` pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4705 ```

@vue/language-server

``` pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4705 ```

@vue/language-service

``` pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4705 ```

vue-tsc

``` pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4705 ```

@vue/typescript-plugin

``` pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4705 ```

Open in Stackblitz

johnsoncodehk commented 2 months ago

LGTM, thanks!