vuejs / language-tools

⚡ High-performance Vue language tooling based-on Volar.js
https://marketplace.visualstudio.com/items?itemName=Vue.volar
MIT License
5.87k stars 405 forks source link

chore: remove `importsNotUsedAsValues` #4897

Closed KazariEX closed 1 month ago

pkg-pr-new[bot] commented 1 month ago

Open in Stackblitz

vue-component-meta

``` pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4897 ```

vue-component-type-helpers

``` pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4897 ```

@vue/language-core

``` pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4897 ```

@vue/language-plugin-pug

``` pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4897 ```

@vue/language-server

``` pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4897 ```

@vue/language-service

``` pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4897 ```

@vue/typescript-plugin

``` pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4897 ```

vue-tsc

``` pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4897 ```

commit: 32f41e0

KazariEX commented 1 month ago

It seems that these changes are not destructive, can try doing it this way.

johnsoncodehk commented 1 month ago

Should we eventually aim for supporting verbatimModuleSyntax=true? I've looked into it and there would be hundreds of necessary changes.

I've tried several times and the current conclusion is that verbatimModuleSyntax is not suitable for CJS projects.

As an alternative to importsNotUsedAsValues, we need to use the equivalent ESLint rule in tsslint.config.ts.