search

vuejs / language-tools

⚡ High-performance Vue language tooling based-on Volar.js
https://marketplace.visualstudio.com/items?itemName=Vue.volar
MIT License
5.87k stars 402 forks source link

chore(vscode): use tsup for tree-shaking #4990

Closed zhiyuanzmj closed 2 weeks ago

pkg-pr-new[bot] commented 2 weeks ago

Open in Stackblitz

vue-component-meta

``` pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4990 ```

vue-component-type-helpers

``` pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4990 ```

@vue/language-plugin-pug

``` pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4990 ```

@vue/language-core

``` pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4990 ```

@vue/language-server

``` pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4990 ```

@vue/language-service

``` pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4990 ```

vue-tsc

``` pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4990 ```

@vue/typescript-plugin

``` pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4990 ```

commit: f3b43c3

johnsoncodehk commented 2 weeks ago

It seems that dist/client.js does not bundle the modules it depends on (reactive-vscode, @volar/vscode...)

zhiyuanzmj commented 2 weeks ago

Oh, I was wrong. The PR can't tree-shaking. It's only use require instead of build-in bundle. But the VSCode plugin don't have node_modules. So I closed the PR.

johnsoncodehk commented 2 weeks ago

No problem, thank you for exploring!