search

vuejs / pinia

🍍 Intuitive, type safe, light and flexible Store for Vue using the composition api with DevTools support
https://pinia.vuejs.org
MIT License
12.91k stars 1.02k forks source link

docs: setup translation infra #2549

Closed Jinjiang closed 7 months ago

Jinjiang commented 8 months ago
netlify[bot] commented 8 months ago

Deploy Preview for pinia-playground canceled.

Name Link
Latest commit 40bfc0c738058f1f0c38ae014c221b6f0f89c0bc
Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/65afc7f561fae10007caa86d
netlify[bot] commented 8 months ago

Deploy Preview for pinia-official ready!

Name Link
Latest commit 40bfc0c738058f1f0c38ae014c221b6f0f89c0bc
Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/65afc7f516bad00008f3ee03
Deploy Preview https://deploy-preview-2549--pinia-official.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ebbb02f) 89.53% compared to head (f6bd586) 89.53%. Report is 3 commits behind head on v2.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v2 #2549 +/- ## ======================================= Coverage 89.53% 89.53% ======================================= Files 11 11 Lines 2875 2875 Branches 232 232 ======================================= Hits 2574 2574 Misses 285 285 Partials 16 16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

awxiaoxian2020 commented 8 months ago

vitepress rc36 released 17 hours ago, should we upgrade to rc36?

Jinjiang commented 8 months ago

vitepress rc36 released 17 hours ago, should we upgrade to rc36?

I upgraded to rc35 just because it supports rtl direction from that version. For other versions I personally don't mind that. However, I think it's not necessary and it could be a separated PR.

Jinjiang commented 7 months ago

@posva would you mind taking a look at this failing test, please? Since I think I didn't change anything related to this test but it failed after my commits. I also ran the same test locally and it succeeded. So I have no idea what is going on.

(and the rest of this PR is ready to review)

Thanks.