vuejs / pinia

🍍 Intuitive, type safe, light and flexible Store for Vue using the composition api with DevTools support
https://pinia.vuejs.org
MIT License
12.72k stars 996 forks source link

docs: fix and update module installation #2621

Closed selemondev closed 3 months ago

selemondev commented 4 months ago

This pull request is intended to fix and update the pinia and @pinia/nuxt module installation by fixing the installation commands.

  1. fix: The pinia package should be installed as a regular dependency while the @pinia/nuxt module should be installed as a dev dependency.
  2. update: I have added pnpm among the package managers to be used when installing pinia and @pinia/nuxt module.
netlify[bot] commented 4 months ago

Deploy Preview for pinia-playground canceled.

Name Link
Latest commit 36bae69b1b6b4a7c7f6c6439e8d9002afebf552a
Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/65ff3545bded7000087d381d
netlify[bot] commented 4 months ago

Deploy Preview for pinia-official ready!

Name Link
Latest commit 36bae69b1b6b4a7c7f6c6439e8d9002afebf552a
Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/65ff35457322650008fe2d19
Deploy Preview https://deploy-preview-2621--pinia-official.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

posva commented 4 months ago

Why the difference? What’s the bug?

selemondev commented 4 months ago

Why the difference? What’s the bug?

Hey @posva . The nuxi CLI, most of the Nuxt modules and the Nuxt devTools install nuxt modules ( including @pinia/nuxt ) as dev dependencies and not as regular dependencies. On the Pinia documentation site, the @pinia/nuxt module is installed as a regular dependency.

posva commented 3 months ago

Thanks. I confirmed with Daniel that this is a thing of the past. Adding it as a dep is fine: https://github.com/nuxt/nuxt/issues/22050