vuejs / pinia

🍍 Intuitive, type safe, light and flexible Store for Vue using the composition api with DevTools support
https://pinia.vuejs.org
MIT License
12.72k stars 996 forks source link

feat(docs): ensure lowercase for the anchor slug #2677

Closed nazarepiedady closed 1 month ago

nazarepiedady commented 1 month ago

In this pull request, I am sending a change that will ensure that the anchor slug will be using lowercase letters.

https://pinia.vuejs.org/introduction.html#Introduction with this change will be https://pinia.vuejs.org/introduction.html#introduction.

netlify[bot] commented 1 month ago

Deploy Preview for pinia-playground canceled.

Name Link
Latest commit 7781ab01e3cdbc560025b36a8560e72187c51c09
Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/665251d1983cbf0008aa58b7
netlify[bot] commented 1 month ago

Deploy Preview for pinia-official ready!

Name Link
Latest commit 7781ab01e3cdbc560025b36a8560e72187c51c09
Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/665251d21324d20008a8b1ec
Deploy Preview https://deploy-preview-2677--pinia-official.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

posva commented 1 month ago

Thanks but this is intended. hash can have upper case and it's needed for API.

BTW, for docs, use doc:. feat and fix are for source code only 🙂

nazarepiedady commented 1 month ago

Thanks but this is intended. hash can have upper case and it's needed for API.

BTW, for docs, use doc:. feat and fix are for source code only 🙂

Oh, but the documentation of vue.js does not follow the same pattern. There, we have APIs with their names capitalised, but the hash is all in lowercase.