vuejs / router

🚦 The official router for Vue.js
https://router.vuejs.org/
MIT License
3.84k stars 1.18k forks source link

fix: keep optional params coming from a parent record #2031

Closed chuyuandu closed 6 months ago

chuyuandu commented 10 months ago

resolve TODO: only keep optional params coming from a parent record

netlify[bot] commented 10 months ago

Deploy Preview for vue-router ready!

Name Link
Latest commit 8fa35748d221ef81446499b4e42fd50cf4bf9482
Latest deploy log https://app.netlify.com/sites/vue-router/deploys/6548c8868c7ec300088b7137
Deploy Preview https://deploy-preview-2031--vue-router.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov-commenter commented 10 months ago

Codecov Report

Merging #2031 (0d414e1) into main (b6d12ed) will increase coverage by 0.02%. Report is 1 commits behind head on main. The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #2031      +/-   ##
==========================================
+ Coverage   90.77%   90.79%   +0.02%     
==========================================
  Files          24       24              
  Lines        1116     1119       +3     
  Branches      348      349       +1     
==========================================
+ Hits         1013     1016       +3     
  Misses         63       63              
  Partials       40       40              
Files Coverage Δ
packages/router/src/matcher/index.ts 98.78% <100.00%> (+0.02%) :arrow_up:

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

chuyuandu commented 10 months ago

@posva hey, i have improved the code and add unit tests

posva commented 10 months ago

thanks! I will check later on this year