vuejs / router

🚦 The official router for Vue.js
https://router.vuejs.org/
MIT License
3.77k stars 1.16k forks source link

docs: support dir in meta for pages #2085

Closed Jinjiang closed 6 months ago

Jinjiang commented 7 months ago

Support adding dir in meta like:

---
dir: rtl
---

The demo screenshot

image

So we can control the direction per each page.

Thanks.

/cc @brc-dd

netlify[bot] commented 7 months ago

Deploy Preview for vue-router ready!

Name Link
Latest commit 46679948d106c885332a837199794dc42b19f606
Latest deploy log https://app.netlify.com/sites/vue-router/deploys/659a9f621f60840009978496
Deploy Preview https://deploy-preview-2085--vue-router.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

posva commented 7 months ago

Shouldn't this be set directly in Vitepress theme 🤔

Jinjiang commented 7 months ago

Yea, I think it's a good idea. Another PR has been created there. :-)

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9ac7d5c) 90.85% compared to head (4667994) 90.85%. Report is 7 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2085 +/- ## ======================================= Coverage 90.85% 90.85% ======================================= Files 24 24 Lines 1115 1115 Branches 347 347 ======================================= Hits 1013 1013 Misses 63 63 Partials 39 39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jinjiang commented 6 months ago

@posva I reset this branch and just bumped the vitepress version. It works as expected from my side. Please take a look. 🙏