vuejs / router

🚦 The official router for Vue.js
https://router.vuejs.org/
MIT License
3.77k stars 1.16k forks source link

docs style error #2096

Closed heygsc closed 6 months ago

heygsc commented 7 months ago

Reproduction

any page with TOC,such as : https://router.vuejs.org/guide/

Steps to reproduce the bug

The right side cannot be fully displayed due to the banner.

image

Expected behavior

It can be fully displayed

Actual behavior

The right side cannot be fully displayed due to the banner.

Additional information

div with a class of "aside container", its padding-top is : calc(var(--vp-nav-height) + var(--vp-layout-top-height, 0px) + var(--vp-doc-top-height, 0px) + 32px)

Perhaps a banner height should be added.

I have participated in submitting a commit before ( https://github.com/vuejs/docs/pull/2572 ) , and it was a similar bug. If possible, I hope to contribute again here.

Looking forward to the proposal of a solution.

posva commented 7 months ago

Feel free to send a PR. It’s related to the banner in the top. I think there a css variable that needs to be set. The problem disappears when closing the banner

heygsc commented 7 months ago

Feel free to send a PR. It’s related to the banner in the top. I think there a css variable that needs to be set. The problem disappears when closing the banner

Okay, I submitted a PR #2098