search

vuejs / router

🚦 The official router for Vue.js
https://router.vuejs.org/
MIT License
3.88k stars 1.18k forks source link

docs: fix typo #2173

Closed make17better closed 6 months ago

make17better commented 7 months ago

Fix typo

Description: A period is missing between instances and Having, click here for details.

Snapshot: 图片

netlify[bot] commented 7 months ago

Deploy Preview for vue-router ready!

Name Link
Latest commit 8c39aaa2f5485466dd7aa25001fb7576900a2bfd
Latest deploy log https://app.netlify.com/sites/vue-router/deploys/65eb2da7c5735a00082dad7e
Deploy Preview https://deploy-preview-2173--vue-router.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

make17better commented 7 months ago

I've already added a period, but why it still doesn't work in the Deploy Preview? Is this caused by the VitePress configuration or the Markdown syntax of VitePress?

make17better commented 7 months ago

Can you fix it in the source code please? This is generated

OK, I got it, I will fix it.

make17better commented 7 months ago

Can you fix it in the source code please? This is generated

Actually, I've changed it in the source code before I open this PR. Seems to be a Netlify deployment issue? Because everything worked fine in the dist I got after I executed pnpm run docs:build locally. Finally, I executed pnpm run docs:preview, it also works.

I'm sorry I can't fix this problem because I can't (or I just don't know how to) debug in a cloud service environment like the Netlify Deploy. Please feel free to enlighten me.

Here's the screenshot of my local preview: 图片

posva commented 6 months ago

I see, thank you. In that case it will appear in the next deployment