Open skirtles-code opened 1 month ago
Name | Link |
---|---|
Latest commit | 79f83dcdf80829bb86a1fd916e7ca3a64345738b |
Latest deploy log | https://app.netlify.com/sites/vue-router/deploys/6646da5689fd5c0008e24471 |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.01%. Comparing base (
d6d4dd3
) to head (79f83dc
). Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Based on #1847.
Currently we have
vue-router.esm-browser.js
, but there isn't a production version of that file.The key benefits of the newly added
vue-router.esm-browser.prod.js
are:@vue/devtools-api
.That second point is important, as various CDNs can automatically apply the minification, but they can't strip out the dependency on
@vue/devtools-api
.The
moduleSideEffects: false
setting is responsible for ensuring@vue/devtools-api
is removed. Without that, we end up withimport "@vue/devtools-api"
in the built file. See https://rollupjs.org/configuration-options/#treeshake-modulesideeffects for details of that setting. While the setting is being applied to all builds, none of the other builds are actually impacted in practice.Do we actually need a production build for
esm-browser
? Not sure, but based on the comments on #1847 and #2241, it does seem that some people would find it useful. An equivalent file is already provided by both Vue Router 3 and Vue core.Closes #1847.