search

vuejs / theme

VitePress theme for vuejs.org.
MIT License
245 stars 87 forks source link

Search shortcut for Windows is broken #35

Closed kiaking closed 2 years ago

kiaking commented 2 years ago

Need to fix this one. The CTRL icon(?) is not looking fantastic.

Screen Shot 2021-11-24 at 22 04 36
Jinjiang commented 2 years ago
image

Seems it's normal now and the shortcut works on my Windows laptop.

@kiaking would you mind a double-check? :-)

Update: I found when you activate the search bar once, the "ctrl" will be changed from a text (my screenshot) into a SVG icon (@kiaking 's screenshot), which looks a little bit smaller. Same to the "meta" on macOS. I feel it's a feature, not a bug.

brc-dd commented 2 years ago

Might wanna backport this: https://github.com/vuejs/vitepress/pull/986

Jinjiang commented 2 years ago

I found another difference is @vue/theme uses <span>s rather than <kbd>s to render the keys. As a result, it shows different styles before and after the actual search box is loaded.

PR created. #71

yyx990803 commented 2 years ago

Closing as it seems to have been fixed