vuejs / theme

VitePress theme for vuejs.org.
MIT License
245 stars 87 forks source link

fix: search style #82

Closed Hongbusi closed 1 year ago

Hongbusi commented 1 year ago

Appearance after one click:

image

image

kiaking commented 1 year ago

I can't reproduce this. What browser are you using...?

Hongbusi commented 1 year ago

I can't reproduce this. What browser are you using...?

Chrome v108 (arm64)

kiaking commented 1 year ago

I'm using the same version but still can't see this happening 🤔

Before Click

Screen Shot 2022-12-16 at 11 06 46

After Click

Screen Shot 2022-12-16 at 11 07 17

Can anyone else reproduce this?

Hongbusi commented 1 year ago

Let friends try it, some can be reproduced, and some can't.

But my access to vitepress is normal.

Jinjiang commented 1 year ago

@kiaking just for more information. The discussion in #78 is quite similar to this one. However, I can't reproduce either of them. For that PR, I just revamped and restructured the CSS code, not targeting any bugs. Maybe there are some edge cases we haven't touched, but I recommend moving forward after having comprehensive reproductions and details this time. Thanks.

kiaking commented 1 year ago

Yeah. Unless we can reproduce this, we can't really fix it. So let's wait to see if anyone can give us feedback on this. And if we don't get it, I think we should just close it.

Jinjiang commented 1 year ago

Agree. I think we can leave this PR open for several days until we receive more information to reproduce it. And once closed, it's still welcome to reopen/recreate. Thanks.

Jinjiang commented 1 year ago

@kiaking I made it reproduced with @Justineo's help. Anyway, in short, the pre-condition is setting the "minimum font size" in Chrome with a non-zero value, which I guess is 12px by default if you choose Chinese as the default locale. That explains how people met the bug but we couldn't reproduce it (my default locale setting is English).

Then I'd like to reopen this PR and retake a look at it. Hope you folks don't mind.

Thanks.

Jinjiang commented 1 year ago

Since no more points for a while, I'd like to merge it if you folks don't mind. Further discussion is always welcome by a new issue or PR. Thanks.