search

vuejs / theme

VitePress theme for vuejs.org.
MIT License
245 stars 87 forks source link

fix: add calculated max height and overflow auto #92

Closed edimitchel closed 1 year ago

edimitchel commented 1 year ago

By adding a calculated max height to the VT Flyout menu and an overflow auto to the VT Menu, this makes the submenu fully accessible again :)

https://user-images.githubusercontent.com/2922851/228395761-bc2ccbf9-ab04-466f-947d-dc9e111b6ca6.mp4

Fixes #91

Jinjiang commented 1 year ago

@edimitchel have you tried it in the demo inside this repo? It seems not working.

image

You can find the online preview from the last Netlify check: https://deploy-preview-92--vue-vitepress-theme.netlify.app/

edimitchel commented 1 year ago

My bad, to be honest I didn't test it with this PR by locally, but I think I did something wrong. Issue is not correctly fixed.

image