search

vuejs / theme

VitePress theme for vuejs.org.
MIT License
245 stars 87 forks source link

Update : Twitter Icon #99

Closed 4ndu-7h4k closed 1 year ago

4ndu-7h4k commented 1 year ago

Updated Twitter icon

Dark Theme image

Light Theme image

4ndu-7h4k commented 1 year ago

Maybe we might wanna change the file name to VTIconX.vue 👀

How about VTIconTwitterX.vue ?

kiaking commented 1 year ago

How about VTIconTwitterX.vue?

Why? It is "X" isn't it? 👀

4ndu-7h4k commented 1 year ago

How about VTIconTwitterX.vue?

Why? It is "X" isn't it? 👀

Yes, updated the changes.

kiaking commented 1 year ago

Looking good to me 👍

@yyx990803 @bencodezen @NataliaTepluhina When do you think is a good timing to ally this change...? 🤔

Jinjiang commented 1 year ago

@kiaking I think we can merge this for now. And then we can further publish it. And then people in the docs project can choose a proper time to apply it.

Let me will check the Netlify checks failure first.