vuejs / ui

💻 UI components for official Vue organization apps
https://vuejs.github.io/ui/
1.33k stars 91 forks source link

Fix useless v-bind:class in VueModal.vue #7

Closed caozhong1996 closed 5 years ago

caozhong1996 commented 6 years ago

There is a line of code :

    <div
      class="vue-ui-modal"
      :class="{
        locked,
      }"
      tabindex="0"
      role="dialog"
      aria-modal="true"
      @keyup.esc="close()"
    >

and it's useless:

      :class="{
        locked,
      }"
Justineo commented 6 years ago

It's not useless. F.Y.I. { locked } is just a shorthand for { locked: locked }.

caozhong1996 commented 6 years ago

It's not useless. F.Y.I. { locked } is just a shorthand for { locked: locked }.

oh, sorry, you are right.But it seems that no class is named 'locked'.