vuejs / v2.vuejs.org

πŸ“„ Documentation for Vue 2
https://v2.vuejs.org
MIT License
5.03k stars 3.42k forks source link

Korean Translation #335

Closed ChangJoo-Park closed 7 years ago

ChangJoo-Park commented 8 years ago

Hello, I just finished translate in Korean.

https://github.com/ChangJoo-Park/vuejs.org

please add http://kr.vuejs.org :)

ChangJoo-Park commented 8 years ago

Translation

Guide

kazupon commented 8 years ago

@ChangJoo-Park Thanks for your translation! Oh Great !! πŸ’―

Do you mistake the above checkboxes ?

I checked your translation repository. I think your translation is perfect if you can translate src/api/index.md.

@yyx990803 We should be added the korean translation repository, if @ChangJoo-Park can maintaine the korean translation repository. πŸ˜‰

ChangJoo-Park commented 8 years ago

@kazupon thank you :) translate api now in progress! I found my mistake there are two APIs.

ChangJoo-Park commented 8 years ago

API has been translated!

kazupon commented 8 years ago

Perfect !! πŸ’―

ChangJoo-Park commented 8 years ago

Too busy to add korean repository? ;)

kazupon commented 8 years ago

/ping @yyx990803

yyx990803 commented 8 years ago

Currently too busy - will take a look after 2.0.

ChangJoo-Park commented 8 years ago

It so sad ;) but understand. I'll wait and ready for 2.0

devjin0617 commented 7 years ago

good! : )

ChangJoo-Park commented 7 years ago

Translate 2.0 version to Korean in progress. please check below. https://github.com/ChangJoo-Park/kr.vuejs.org

Guide (ordering number)

API

Others

Not reviewed yet.

old (1.0) version is here https://github.com/EndlessCreation/old.vuejs.org

ν•œκ΅­μ–΄ μ‚¬μš©μž λΆ„λ“€κ»˜ (For Korean): ν•œκ΅­μ–΄ λ²ˆμ—­ 및 μ˜κ²¬μ€ ν•œκΈ€ λ²ˆμ—­ μ €μž₯μ†Œμ˜ 이슈둜 μ˜κ²¬μ„ μ£Όμ‹œλ©΄ λ°˜μ˜ν•˜κ² μŠ΅λ‹ˆλ‹€.

kazupon commented 7 years ago

@ChangJoo-Park awesome!

Can you maintain korean translation repository continue from now? If possible, I hope that want to join to you as maintainer.

@chrisvfritz @yyx990803 What do you think?

ChangJoo-Park commented 7 years ago

@kazupon Yes, I hope many Korean users enter Vue world easily :)

ChangJoo-Park commented 7 years ago

Almost everything has been translated. Except Example and Other.

Now I start a review for Guide and API.

ChangJoo-Park commented 7 years ago

@kazupon Everything is done! (Actually without dropdown.) this is my repo. https://github.com/ChangJoo-Park/kr.vuejs.org

yyx990803 commented 7 years ago

Looks like you have setup a custom domain for your github.io site - can you try adding src/CNAME with kr.vuejs.org and redeploy?

ChangJoo-Park commented 7 years ago

@yyx990803 I remove custom domain from my github.io site. and redeploy with CNAME.

"Domain change"(my changjoo.me domain -> does not point github) will probably take effect within a few hours.

yyx990803 commented 7 years ago

@ChangJoo-Park thanks! The site should now be live at kr.vuejs.org - wasn't obvious at first sight because the homepage is still English ;) Maybe you'd want to translate the homepage as well?

yyx990803 commented 7 years ago

@ChangJoo-Park btw, thanks for your hard work! When you feel that it is ready, you can submit a PR to add a link to the Korean docs here: https://github.com/vuejs/vuejs.org/blob/master/themes/vue/layout/partials/language_dropdown.ejs

ChangJoo-Park commented 7 years ago

@yyx990803 thank you! Evan πŸ‘

When I am ready, I'll create PR.

ChangJoo-Park commented 7 years ago

Create PR for dropdown.

ChangJoo-Park commented 7 years ago

Translated TypeScript Support in Korean.

ChangJoo-Park commented 7 years ago

[Question] Can I change this line?

Original to Korean

I think this is not my own project. I am just contributor, not owner. So, Exposing my account does not make sense.

@kazupon , @yyx990803 . I want to hear your opinion.

kazupon commented 7 years ago

@ChangJoo-Park Yeah! In this context, due to this sentence makes sense for this repository, You can change Korean translation repo.

ref: japanese

yyx990803 commented 7 years ago

@ChangJoo-Park if you are concerned about exposing your personal account, you can create an organization e.g. vuejs-kr and move the forked repo into that organization.

ChangJoo-Park commented 7 years ago

Thank you for response. I create vuejs-kr organization ! github organization link is here. I hope kr.vue.org managed by commnuity. Thanks @kazupon @yyx990803

ChangJoo-Park commented 7 years ago

add automatic build kr.vuejs.org using travis-ci.

ChangJoo-Park commented 7 years ago

Add algolia docsearch. @kciter κ°μ‚¬ν•©λ‹ˆλ‹€.

ref: #575 , #661

ChangJoo-Park commented 7 years ago

Add Production deployment tip. modify single file component

ChangJoo-Park commented 7 years ago

Add Vue in 2016 , change google analytics.

I started collecting statistics for users of Korean pages.

ChangJoo-Park commented 7 years ago

Updated for 2.2.0

sdras commented 7 years ago

It seems to me reading through this that this translation was complete about a year ago, so I am closing out this issue. Please feel free to reopen if I'm mistaken. Thank you so much for the contribution! πŸŽ‰

ChangJoo-Park commented 7 years ago

@sdras, docs in Korean has maintained in https://github.com/vuejs-kr/kr.vuejs.org/ this repo.

:)