Closed ChangJoo-Park closed 7 years ago
Translation
Guide
[ ] Other
Guide (Reviewing)
@ChangJoo-Park Thanks for your translation! Oh Great !! π―
Do you mistake the above checkboxes ?
I checked your translation repository.
I think your translation is perfect if you can translate src/api/index.md
.
@yyx990803 We should be added the korean translation repository, if @ChangJoo-Park can maintaine the korean translation repository. π
@kazupon thank you :) translate api now in progress! I found my mistake there are two APIs.
API has been translated!
Perfect !! π―
Too busy to add korean repository? ;)
/ping @yyx990803
Currently too busy - will take a look after 2.0.
It so sad ;) but understand. I'll wait and ready for 2.0
good! : )
Translate 2.0 version to Korean in progress. please check below. https://github.com/ChangJoo-Park/kr.vuejs.org
Guide (ordering number)
API
Others
Not reviewed yet.
old (1.0) version is here https://github.com/EndlessCreation/old.vuejs.org
νκ΅μ΄ μ¬μ©μ λΆλ€κ» (For Korean): νκ΅μ΄ λ²μ λ° μ견μ νκΈ λ²μ μ μ₯μμ μ΄μλ‘ μ견μ μ£Όμλ©΄ λ°μνκ² μ΅λλ€.
@ChangJoo-Park awesome!
Can you maintain korean translation repository continue from now? If possible, I hope that want to join to you as maintainer.
@chrisvfritz @yyx990803 What do you think?
@kazupon Yes, I hope many Korean users enter Vue world easily :)
Almost everything has been translated. Except Example
and Other
.
Now I start a review for Guide and API.
@kazupon Everything is done! (Actually without dropdown.) this is my repo. https://github.com/ChangJoo-Park/kr.vuejs.org
Looks like you have setup a custom domain for your github.io site - can you try adding src/CNAME
with kr.vuejs.org
and redeploy?
@yyx990803 I remove custom domain from my github.io site. and redeploy with CNAME.
"Domain change"(my changjoo.me domain -> does not point github) will probably take effect within a few hours.
@ChangJoo-Park thanks! The site should now be live at kr.vuejs.org
- wasn't obvious at first sight because the homepage is still English ;) Maybe you'd want to translate the homepage as well?
@ChangJoo-Park btw, thanks for your hard work! When you feel that it is ready, you can submit a PR to add a link to the Korean docs here: https://github.com/vuejs/vuejs.org/blob/master/themes/vue/layout/partials/language_dropdown.ejs
@yyx990803 thank you! Evan π
When I am ready, I'll create PR.
Create PR for dropdown.
Translated TypeScript Support in Korean.
@ChangJoo-Park Yeah! In this context, due to this sentence makes sense for this repository, You can change Korean translation repo.
ref: japanese
@ChangJoo-Park if you are concerned about exposing your personal account, you can create an organization e.g. vuejs-kr
and move the forked repo into that organization.
Thank you for response. I create vuejs-kr organization ! github organization link is here. I hope kr.vue.org
managed by commnuity. Thanks @kazupon @yyx990803
add automatic build kr.vuejs.org using travis-ci.
Add algolia docsearch. @kciter κ°μ¬ν©λλ€.
ref: #575 , #661
Add Production deployment tip. modify single file component
Add Vue in 2016 , change google analytics.
I started collecting statistics for users of Korean pages.
Updated for 2.2.0
It seems to me reading through this that this translation was complete about a year ago, so I am closing out this issue. Please feel free to reopen if I'm mistaken. Thank you so much for the contribution! π
@sdras, docs in Korean has maintained in https://github.com/vuejs-kr/kr.vuejs.org/ this repo.
:)
Hello, I just finished translate in Korean.
https://github.com/ChangJoo-Park/vuejs.org
please add http://kr.vuejs.org :)