vuejs / vitepress

Vite & Vue powered static site generator.
https://vitepress.dev
MIT License
12.89k stars 2.08k forks source link

Character Appearance changed vom 1.0.0-alpha.13 to 1.0.0-alpha.14 #1362

Closed MarkusKeck closed 2 years ago

MarkusKeck commented 2 years ago

Describe the bug

The character appearance changed from vitepress version 1.0.0-alpha.13 to 1.0.0-alpha.14.

The character: https://www.compart.com/de/unicode/U+21A9

↩︎ gets now displayed as icon. Before it was displayed as normal entity.

I am currently using markdown-it-footnote which uses this character to link at every occurence of the given footnote.

Before: image

After: image

Reproduction

Use markdown-it-footnote with both versions.

Expected behavior

Should not display the character as icon

System Info

System:
    OS: Windows 10 10.0.19044
    CPU: (32) x64 AMD Ryzen 9 3950X 16-Core Processor
    Memory: 107.12 GB / 127.91 GB
  Binaries:
    Node: 16.14.2 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.7.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (105.0.1343.42)
    Internet Explorer: 11.0.19041.1566
  npmPackages:
    vitepress: ^1.0.0-alpha.14 => 1.0.0-alpha.14

Additional context

No response

Validations

brc-dd commented 2 years ago

It's still a unicode character. It depends on your available fonts what it will be rendered like. Unless a suitable font (having glyph for that character) is explicitly defined in theme, it will be system and browser dependent.

MarkusKeck commented 2 years ago

But what did you change from 1.0.0-alpha.13 to 1.0.0-alpha.14. The system and browser are still the same. Did you introduce a new font? Which property do I need to modify to have the old behaviour?

brc-dd commented 2 years ago

Try overriding the font family (--vp-font-family-base). Earlier there were no symbol fonts specified so it was falling back to whatever your browser uses. https://github.com/vuejs/vitepress/commit/8d6a20d66542e4d13cc5958bb3733928f9778027

MarkusKeck commented 2 years ago

Thanks for that information. I will try that