Closed awxiaoxian2020 closed 6 months ago
@brc-dd How do you think the VitePress i18n docs config structure should be better?
Add zh directory, keep english one on the root. This way it won't break the URLs.
Add zh directory, keep english one on the root. This way it won't break the URLs.
What I said is config like nav
. Where should I add zh
nav? in docs/.vitepress/config.ts
directly?
Ah okay. You can create a config directory and create two files (en.ts and zh.ts). and merge/reexport them from config/index.ts. It would be cleaner that way.
Welcome to review by clicking here!
@brc-dd Could we add a netlify bot for previewing directly like this?
Deploy previews are already enabled. Just the bot isn't added to prevent noise. One can open the deploy preview like this:
(Click on details aside deploy/netlify.)
Deploy previews are already enabled. Just the bot isn't added to prevent noise. One can open the deploy preview like this:
(Click on details aside deploy/netlify.)
OK thanks!
Hi! Thank you so much on working on this translations 🙏 Just to let you know, I'm planning to go through whole docs before stable release, and might restructure the contents here and there. So, please do not work too hard on this since I don't want to break your work badly 😅
Hi! Thank you so much on working on this translations 🙏 Just to let you know, I'm planning to go through whole docs before stable release, and might restructure the contents here and there. So, please do not work too hard on this since I don't want to break your work badly 😅
Got it! Thanks!
Hi! Seems like Evan had done whole doc rewrites and it's done now. I think you should expect that the doc is quite fixed 👍
@brc-dd Could we consider merging this PR now?
Hi, I assume the config should be moved to docs/.vitepress/config/index.ts
, compare the pro tip at the end of the relevant vitepress
docs section at:
https://vitepress.dev/guide/i18n#internationalization
Also, this might help as a reference:
Could we consider merging this PR now?
Yeah I'll ask the translations team to review it. 👍
Could we consider merging this PR now?
Yeah I'll ask the translations team to review it. 👍
It has many typos indeed. But maintaining it here by myself is so hard. It's so large.
Closing as support #2249.
close #1285.
You can preview it at https://deploy-preview-2249--vitepress-docs.netlify.app/zh/
It will be ready for review after: