Closed vanchKong closed 4 months ago
So should I close my PR? I'm busy these days indeed...But I actually want to update it later...
@awxiaoxian2020 Let's keep both open for now. We'll decide once we reach beta.
I don't think we need two translation PRs because our goal is the same one. @vanchKong Could you please add me and @shellRaining collaborate your repo so that we can opt the translations conveniently?
I will close my PR at an appropriate time.
Okay sure. Yeah it will be better if you all can collaborate together. Initially I was thinking to cherry pick stuff from both. So yeah if we can have one PR with best of both, then that would be great.
could use zh-Hans/zh-Hant instead zh-CN?
I don't think we need two translation PRs because our goal is the same one. @vanchKong Could you please add me and @shellRaining collaborate your repo so that we can opt the translations conveniently?
I will close my PR at an appropriate time.
Done! sorry for the late reply
@vanchKong Please fix typo in title, it's translation
.
What's the plan about this pr? @brc-dd
The PR will be considered when the VitePress is at release stage.@vanchKong
Yeah, like @awxiaoxian2020 said. It'll be merged as we are close to v1.
Just a tip -- run npx simple-git-hooks
-- it will add prettier to your git hooks, and CI won't fail because of that then (unless you're running git commit with --no-verify
).
Hi guys, thanks a lot for maintaining this! Is this ready to merge or are there any blockers/TODOs? If you guys are fine, we can merge this by this week. (we are planning to release v1 in few days)
@brc-dd I have checked these files to ensure the translations line by line with the English content, and we have over 10000 rows which is not perfect but can be improved by contributors easily. So on my side, This PR can be merged now.
commit about:
zh-CN
translation, synced to1.0.0-rc.29
Add markdown basic usage documentationtranslation details:
I'll follow up with updates to the docs (my own repository: vanchKong/VitePressCN & site)preview link https://deploy-preview-2249--vitepress-docs.netlify.app/