Open olets opened 4 weeks ago
(sorry for that noise. almost never resolve merge conflicts via the github UI and forgot it would merge the base into the feature. disregard the "'main' into sidebar-details", it's reverted)
Also, regarding #3805 I don't think that's a bug. If I am on this state:
I would want clicking next page will uncollapse the "Writing" section in sidebar.
Also, the tests seem to be failing, please update those too.
Thanks for the feedback. Been meaning to say that I see the failing tests and will look at them. Will try to find time for this soon.
(ignore that test rerun — I only rebased, should still fail)
I have the updates locally. Waiting on https://github.com/vuejs/core/pull/10938 then will push them up.
@brc-dd do you have a preference for whether I make new commits or rewrite commits? If new commits, chore
type to keep "feat: update the new feature" noise out of the changelog?
No preference. You can just keep pushing things. No need to write in conventional commit format too. We do squash and merge, so it's the PR title that matters. Commit messages of individual commits will be ignored. You don't need to maintain linear history either, feel free to just merge things instead of rebase or force-pushes.
Closes #3804
3804
Fixes #3517, closes # 3802 as obviated
3517
Fixes #3805
3805
3804 is the primary target of this PR. Preserving the behaviors identified in 3517 and 3805 would have taken additional work, so I took the opportunity to address them for "free".
Before
Sidebar collapsible groups used custom markup and JS. Carets are focusable, an accessibility problem.
After
<details>
elements. Custom markup and JS is reduced.To test
With the released version, replace
docs/.vitepress/config/en.ts
'ssidebarGuide
with the following.pnpm run docs
http://localhost:<your port>/guide/what-is-vitepress
in a browser