search

vuejs / vue-cli

🛠️ webpack-based tooling for Vue.js Development
https://cli.vuejs.org/
MIT License
29.78k stars 6.33k forks source link

update @apollographql dependencies #5687

Open Halkcyon opened 3 years ago

Halkcyon commented 3 years ago

What problem does this feature solve?

Ability to use vuejs in corporate environments with automated license checks for controls & compliance.

In particular, these dependencies cause friction for me on @vue/cli@4.4.6:

What does the proposed API look like?

The project moved from graphql/graphql-language-service to graphql/graphiql.

The change may ultimately be upstream, but this project is where I feel it.

Halkcyon commented 3 years ago

A quick yarn why reveals the following:

=> Found "@apollographql/graphql-language-service-interface@2.0.2"
info Reasons this module exists
   - "@vue#cli#@vue#cli-ui#vue-cli-plugin-apollo#apollo#apollo-language-server" depends on it
   - Hoisted from "@vue#cli#@vue#cli-ui#vue-cli-plugin-apollo#apollo#apollo-language-server#@apollographql#graphql-language-service-interface"

=> Found "@apollographql/graphql-language-service-parser@2.0.2"
info Reasons this module exists
   - "@vue#cli#@vue#cli-ui#vue-cli-plugin-apollo#apollo#apollo-language-server#@apollographql#graphql-language-service-interface" depends on it
   - Hoisted from "@vue#cli#@vue#cli-ui#vue-cli-plugin-apollo#apollo#apollo-language-server#@apollographql#graphql-language-service-interface#@apollographql#graphql-language-service-parser"

=> Found "@apollographql/graphql-language-service-types@2.0.2"
info Reasons this module exists
   - "@vue#cli#@vue#cli-ui#vue-cli-plugin-apollo#apollo#apollo-language-server#@apollographql#graphql-language-service-interface" depends on it
   - Hoisted from "@vue#cli#@vue#cli-ui#vue-cli-plugin-apollo#apollo#apollo-language-server#@apollographql#graphql-language-service-interface#@apollographql#graphql-language-service-types"
   - Hoisted from "@vue#cli#@vue#cli-ui#vue-cli-plugin-apollo#apollo#apollo-language-server#@apollographql#graphql-language-service-interface#@apollographql#graphql-language-service-parser#@apollographql#graphql-language-service-types"
   - Hoisted from "@vue#cli#@vue#cli-ui#vue-cli-plugin-apollo#apollo#apollo-language-server#@apollographql#graphql-language-service-interface#@apollographql#graphql-language-service-utils#@apollographql#graphql-language-service-types"

=> Found "@apollographql/graphql-language-service-utils@2.0.2"
info Reasons this module exists
   - "@vue#cli#@vue#cli-ui#vue-cli-plugin-apollo#apollo#apollo-language-server#@apollographql#graphql-language-service-interface" depends on it
   - Hoisted from "@vue#cli#@vue#cli-ui#vue-cli-plugin-apollo#apollo#apollo-language-server#@apollographql#graphql-language-service-interface#@apollographql#graphql-language-service-utils"
Halkcyon commented 3 years ago

It looks like #5663 was opened for the same issue, but closed without resolution and only points at one such link meanwhile my issue has four links. I'd like to offer patches and get this resolved, but I don't have experience navigating monorepos and github searches seem inadequate.

antonioaguilar commented 3 years ago

is there an update on this issue? It's currently blocking the installation of the @vue/cli in enterprise environments.

Halkcyon commented 3 years ago

@sodatea I see you in #5663 pointed @antonioaguilar on which dependency needs to be updated. What led you to finding that? I'd like to get this pair of issues resolved.

sodatea commented 3 years ago

I looked at the first section of the yarn why output and then looked for the package.json of each package that appeared in the result to see which one was using the outdated dependency.

=> Found "@apollographql/graphql-language-service-interface@2.0.2"
info Reasons this module exists
   - "@vue#cli#@vue#cli-ui#vue-cli-plugin-apollo#apollo#apollo-language-server" depends on it
   - Hoisted from "@vue#cli#@vue#cli-ui#vue-cli-plugin-apollo#apollo#apollo-language-server#@apollographql#graphql-language-service-interface"
                                                                     ^
ntregillus commented 2 years ago

any ETA on this? these are red flags that I have to explain to our InfoSec team regularly.