vuejs / vue-cli

🛠️ webpack-based tooling for Vue.js Development
https://cli.vuejs.org/
MIT License
29.75k stars 6.32k forks source link

node-fibers has to be removed #6522

Closed baybal closed 3 years ago

baybal commented 3 years ago

Version

5.0.0-beta.1

Environment info

<pre><b>Environment Info:</b>

  System:
    OS: Linux 5.4 Ubuntu 20.04.2 LTS (Focal Fossa)
    CPU: (2) x64 Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
  Binaries:
    Node: 16.3.0 - /usr/bin/node
    Yarn: Not Found
    npm: 7.15.1 - /usr/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: Not Found
  npmPackages:
    @vue-leaflet/vue-leaflet: ^0.6.0 =&gt; 0.6.0 
    @vue/cli-overlay:  5.0.0-beta.1 
    @vue/cli-plugin-e2e-webdriverio: ~5.0.0-beta.1 =&gt; 5.0.0-beta.1 
    @vue/cli-plugin-eslint: ~5.0.0-beta.1 =&gt; 5.0.0-beta.1 
    @vue/cli-plugin-router: ~5.0.0-beta.1 =&gt; 5.0.0-beta.1 
    @vue/cli-plugin-unit-jest: ~5.0.0-beta.1 =&gt; 5.0.0-beta.1 
    @vue/cli-plugin-vuex: ~5.0.0-beta.1 =&gt; 5.0.0-beta.1 
    @vue/cli-service: ~5.0.0-beta.1 =&gt; 5.0.0-beta.1 
    @vue/cli-shared-utils:  5.0.0-beta.1 
    @vue/compiler-core:  3.1.1 
    @vue/compiler-dom:  3.1.1 
    @vue/compiler-sfc: ^3.1.1 =&gt; 3.1.1 
    @vue/compiler-ssr:  3.1.1 
    @vue/component-compiler-utils:  3.2.0 
    @vue/devtools-api:  6.0.0-beta.12 
    @vue/eslint-config-standard: ^6.0.0 =&gt; 6.0.0 
    @vue/eslint-config-typescript: ^7.0.0 =&gt; 7.0.0 
    @vue/reactivity:  3.1.1 
    @vue/runtime-core:  3.1.1 
    @vue/runtime-dom:  3.1.1 
    @vue/shared:  3.1.1 
    @vue/test-utils: ^2.0.0-0 =&gt; 2.0.0-rc.4 
    @vue/web-component-wrapper:  1.3.0 
    eslint-plugin-vue: ^7.9.0 =&gt; 7.10.0 
    jest-serializer-vue:  2.0.2 
    typescript: ~4.1.5 =&gt; 4.1.5 
    vue: ^3.1.1 =&gt; 3.1.1 
    vue-class-component: ^8.0.0-0 =&gt; 8.0.0-rc.1 
    vue-eslint-parser:  7.6.0 
    vue-hot-reload-api:  2.3.4 
    vue-jest: ^5.0.0-0 =&gt; 5.0.0-alpha.10 
    vue-loader:  16.2.0 (15.9.7)
    vue-router: ^4.0.8 =&gt; 4.0.6 
    vue-style-loader:  4.1.3 
    vue-template-es2015-compiler:  1.9.1 
    vue3-charts: ^1.1.17 =&gt; 1.1.17 
    vuex: ^4.0.1 =&gt; 4.0.1 
  npmGlobalPackages:
    @vue/cli: 5.0.0-beta.1</pre>

Steps to reproduce

Install nodejs 16 and CLI 5

Run run build

What is expected?

Should work

What is actually happening?

Crash


Upstream V8, and nodejs will no longer support thread ID visibility in the API, very likely an intentional decision.

Fibers like hacks are now effectively dead for node 16.0

hmmdeif commented 3 years ago

N.B. it's just @vue/cli-plugin-e2e-webdriverio that has it as a dependency. sass-loader also has it as a peer dependency so you have to use npm i --legacy-peer-deps on npm@7, which is annoying.

haoqunjiang commented 3 years ago

As of sass-loader v12, it stops auto importing fiber on Node.js >= 16.

And we'll remove @wdio/sync in the next major now that it is deprecated

baybal commented 3 years ago

@sodatea I still see fiber being pulled in @ latest . Are you sure it's sass-loader v12 by default?

Aymkdn commented 1 year ago

For people coming from Google and who receive the error ## There is an issue with node-fibers ## and fibers.node is missing., you can just uninstall it:

npm uninstall -D fibers

(See the vue-cli documentation)