search

vuejs / vue-component-compiler

Compile a single file Vue component into a CommonJS module.
MIT License
343 stars 52 forks source link

Work around "template" changes in parse5 >= 1.2.0 #2

Closed robotblake closed 9 years ago

robotblake commented 9 years ago

parse5 >= 1.2.0 has made changes to support the template element spec

https://html.spec.whatwg.org/multipage/scripting.html#the-template-element

yyx990803 commented 9 years ago

Thanks a lot!

inikulin commented 9 years ago

Hi, guys, I'm a parse5 author. I'm just wonder why you need such workaround? parse5 should directly serialize <template> content implicitly skipping it's fragment element as defined in spec: https://github.com/inikulin/parse5/blob/master/lib/serialization/serializer.js#L108. Am I missing something and it should be fixed on my side?

yyx990803 commented 9 years ago

@inikulin This project actually wants to extract the content of the fragment, so I don't think there's anything wrong with parse5's implementation.

inikulin commented 9 years ago

@yyx990803 Thank you for the clarification. I just try to monitor the adoption of the new version, because spec-compliant <template> parsing caused various issues in dependent packages. Let me know if you will need any farther assistance.