search

vuejs / vue-component-compiler

Compile a single file Vue component into a CommonJS module.
MIT License
342 stars 52 forks source link

add src attribute support #3

Closed jabez128 closed 9 years ago

jabez128 commented 9 years ago
  1. the parameter '"cb" in compile function and the parameter "cb" in jobs cause some code reading confusion，I think change one name could be better :)
  2. add src attribute support
yyx990803 commented 9 years ago

Several suggestions:

  1. In general I don't accept code-style related PRs unless there's a valid reason. I don't think the cb -> done change here makes a convincing point.
  2. Don't mix multiple changes in the same PR, especially when one is about code style and the other is about functionality.
  3. Make sure you changes conform to the existing code formatting (tabs vs. 2 spaces)
jabez128 commented 9 years ago

fine and I will close this PR and submit another:)