search

vuejs / vue-component-compiler

Compile a single file Vue component into a CommonJS module.
MIT License
342 stars 52 forks source link

Should assemble require customBlocks? #32

Closed eddyerburgh closed 6 years ago

eddyerburgh commented 6 years ago

I imagine there will be users who don't want to process custom blocks, but want to use vue-component-compiler.

I don't think customBlocks should be a required argument for assemble

znck commented 6 years ago

I feel same. It shouldn't be a required argument.

znck commented 6 years ago

You can ignore custom blocks by passing an empty array. I believe current API (requiring custom blocks) does not limit users; we can keep it as it is.

eddyerburgh commented 6 years ago

If we can ignore by passing an empty array, I think we should also be able to leave it undefined.

znck commented 6 years ago

Custom blocks optional after #53