search

vuejs / vue-component-compiler

Compile a single file Vue component into a CommonJS module.
MIT License
342 stars 52 forks source link

Order of postcss modules when provided other postcss plugins #84

Open lancetharper opened 5 years ago

lancetharper commented 5 years ago

I'm using rollup-plugin-vue and noticed that if I use postcss-import (or any other postcss plugins to use as a replacement for less/sass) that the module'd class names are not added to the $style object for classes that are contained within imported stylesheets.

I believe it is because postcss-modules is prepended and run before my other supplied plugins here. I can confirm that by inverting and concat'ing the postcss modules fixes the issue for me, however I'm curious if there is a deeper reason for prepending it.

You can find my original issue here for reproduction.

I'm happy to put together a PR if no one sees any reason not to do this.

ztamizzen commented 5 years ago

Any progress?

lancetharper commented 5 years ago

@ztamizzen No response yet. I assume they've been busy with the recent Vue Conference.

The change itself would be pretty small/simple so once we get some guidance here the fix (if any) would be quick and easy.