Title mixin should use provide() for Vue 2.4.x

vuejs / vue-hackernews-2.0

HackerNews clone built with Vue 2.0, vue-router & vuex, with server-side rendering

MIT License

10.95k stars 2.15k forks source link

Title mixin should use provide() for Vue 2.4.x #230

Open aeharding opened 7 years ago

aeharding commented 7 years ago

I used the title mixin in my app with SSR and upgrading to 2.4.0 lead to the dreaded mergeData stack overflow exception.

Wrapping the static delaration in a provide() function fixes it.

https://github.com/vuejs/vue-hackernews-2.0/blob/master/src/util/title.js

vuejs/vue#6190

aeharding commented 7 years ago

Well, after some investigation, I can't get this to work when wrapping with provide(). I guess I don't understand mixins well enough. I also can't seem to duplicate the stack overflow with this project, but I can with mine (using the exact same mixin). Removing the title mixin from my project makes the error disappear as well.

Any advice is appreciated. For now, I guess I'm stuck on 2.3.x.