search

vuejs / vue-hackernews-2.0

HackerNews clone built with Vue 2.0, vue-router & vuex, with server-side rendering
MIT License
10.96k stars 2.15k forks source link

Webpack 4 migration? #292

Open asadsahi opened 6 years ago

asadsahi commented 6 years ago

Any plans of migrations to webpack 4?

danzlarkin commented 6 years ago

I'm currently working on a Pull Request at the moment.

All is functioning in development mode, but still working on a patch for the "extract-text-webpack-plugin" which is causing an error in production mode.

Webpack 4.0 is still quite buggy, as many plugins aren't updated as of yet.

asadsahi commented 6 years ago

@larkin-nz I realised it as well some warnings with extract-text-webpack-plugin. Existing webpack 4 upgrade pull request works with similar warnings but it produces the bundle correctly and works for me. What error do you receive?

danzlarkin commented 6 years ago

The issues that I'm having occurring in production mode are causing Webpack not to serve the CSS files to the browser.

asadsahi commented 6 years ago

This sounds slightly similar issue I was having when I upgraded webpack-dev-middleware to 3.x but had to revert back to 2.x. The issue I was having was on Windows OS and it was for all static files not being served because of some path malformed.

But yours might be a different issue.

danzlarkin commented 6 years ago

Interesting, I'm running a Unix-like architecture and it seems to run fine in development mode.

I'll do some debugging tomorrow and have a look at that.

mkastner commented 6 years ago

I'm also looking forward to this working with Vue 4.x

SarasArya commented 6 years ago

Any updates on this ? Looking forward to it.