vuejs / vue-hackernews-2.0

HackerNews clone built with Vue 2.0, vue-router & vuex, with server-side rendering
MIT License
10.96k stars 2.15k forks source link

Fix: Removed loading icon when there are no comments #341

Closed tbezman closed 2 years ago

tbezman commented 5 years ago

Previous to this commit, if you view a thread which has zero comments, the loading property never gets set to false.

I'm not sure if the approach I used was correct, maybe you could guide me in the right direction if something about it smells.