search

vuejs / vue-jest

Jest Vue transformer
MIT License
746 stars 157 forks source link

fix: PostCSS mixins cause style parsing to break #425

Closed sevilyilmaz closed 2 years ago

sevilyilmaz commented 2 years ago

Replaced extract-from-css which is outdated (7yo) with css-tree.

Resolves #424

sevilyilmaz commented 2 years ago

@lmiller1990 could you have a look at this? The issue is a blocker for me.

sevilyilmaz commented 2 years ago

@cexbrayat, @lmiller1990, are there any blockers prevent this PR to be merged?

lmiller1990 commented 2 years ago

No problem, just a lack of resources and time. Do you know what the CI build is failing?

sevilyilmaz commented 2 years ago

I see. The jobs have been failing in the previous commits as well in the master with the same message: "No configuration was found in your project.". It seems something related to the CircleCI config. It doesn't seem related to this PR.

cexbrayat commented 2 years ago

Yeah it's because we dropped CircleCI @lmiller1990 (see https://github.com/vuejs/vue-jest/pull/413 where I mentioned I did not have the access to remove this build)

You can safely ignore it 👍

lmiller1990 commented 2 years ago

Ok, gotta do a release soon. I REALLY want semantic release set up at some point, I'm starting to become the bottleneck.

sevilyilmaz commented 2 years ago

Do you have any plans for this change to be released soon?

lmiller1990 commented 2 years ago

I will do it by the end of the week. Ping me if it isn't out by then.

I am not working on vue-jest much lately, it definitely needs some support, thus sllow releases. If anyone is reading and would like to make a PR adding semantic release support and speed things up, that'd be great.

sevilyilmaz commented 2 years ago

Hi @lmiller1990, friendly reminder, this change is not released yet.

I would love to contribute for the semantic release but these days I don't have bandwidth for that.

lmiller1990 commented 2 years ago

I tried to release this just now but CI failed https://github.com/vuejs/vue-jest/actions/workflows/node.yml

I am not sure what's going on, I'll look into it.

lmiller1990 commented 2 years ago

If you can fix CI before I do, we can release v27. I'm sorry I haven't been able to do this - I do not use Vue Jest, it's hard to prfioritize this.

We really need an active maintainer, but seems no-one is super keen on doing so right now.

lmiller1990 commented 2 years ago

I released v27.0.0. https://github.com/vuejs/vue-jest/releases/tag/v27.0.0

I hope your issue is resolved now! If not, please open an issue and/or post a PR.

sevilyilmaz commented 2 years ago

Yes, it solved my issue. Thank you for taking time to release the package.