search

vuejs / vue-jest

Jest Vue transformer
MIT License
746 stars 157 forks source link

Issue #417: Should not return empty string so that it is compatible w… #428

Closed lptai closed 2 years ago

lptai commented 2 years ago

Fix issue mentioned here https://github.com/vuejs/vue-jest/issues/417

lmiller1990 commented 2 years ago

Can you try merging in the latest master? Sorry for the slow response.

Magiczne commented 2 years ago

@lptai will you update this PR? If not i will go and create a fresh one based on the current master, cause that bug is holding me in my projects

lptai commented 2 years ago

Doing it now @Magiczne

lptai commented 2 years ago

Can you try merging in the latest master? Sorry for the slow response.

updated to latest master @lmiller1990

lmiller1990 commented 2 years ago

Will review soon, thanks.

lmiller1990 commented 2 years ago

It's released. https://github.com/vuejs/vue-jest/releases/tag/v28.0.0

You might need to update to Jest 28 to get this; I don't think it got in the last release for v27. If this is big problem, let me know, but updating to the latest Jest is always a good idea.