search

vuejs / vue-jest

Jest Vue transformer
MIT License
748 stars 156 forks source link

Fix source maps for vue2-jest #486

Closed NikhilVerma closed 2 years ago

NikhilVerma commented 2 years ago

The code has been borrowed from vue3-jest

For me this fixes: https://github.com/vuejs/vue-jest/issues/474

lmiller1990 commented 2 years ago

CI is failing - can you take a look?

NikhilVerma commented 2 years ago

@lmiller1990 I've fixed the test issues, it was a path mismatch between my machine and the github CI agent. Can you pls re-run the CI? I don't have the permissions to do so.

john-maddock commented 2 years ago

@NikhilVerma @lmiller1990 im using vue2-jest but not using typescript, im also having source map issues. Wondering will this fix it for ?..

lmiller1990 commented 2 years ago

Looks good, I'll leave this open until I've got bandwidth to release, that should be in the next few days. Ping me if it does not happen.

@john-maddock no idea, you could test it out by just copy pasting the changes into your node_modules/vue-jest directory - no need to compile, it's regular JS.

lmiller1990 commented 2 years ago

Let's wait for https://github.com/vuejs/vue-jest/pull/483 to merge, then I'll merge this and release the new version.

lmiller1990 commented 2 years ago

Let's just ship this.

lmiller1990 commented 2 years ago

It's out https://github.com/vuejs/vue-jest/releases/tag/v28.1.0