search

vuejs / vue-jest

Jest Vue transformer
MIT License
748 stars 156 forks source link

fix(tsconfig): parse extended tsconfigs when transpiling script blocks #502

Closed thebanjomatic closed 2 years ago

thebanjomatic commented 2 years ago

A change introduced in v28.1.0 in PR #471 unintentionally changed the behavior of the tsconfig parsing such that configs using "extends" were no longer being considered.

Fixes: #495

thebanjomatic commented 2 years ago

@lmiller1990 I wouldn't mind back-patching this to vue-jest v28.x also, but there isn't a branch to target for that. What is the process for backpatching? I support infrastructure that wraps around these tools and I'm currently having to workaround this problem in my project's v28 branch, so it would be nice to be able to remove the workaround in both places.

[Update] I'm just going to release jest 28 and jest 29 support for my package using the workaround. I will probably update the jest 29 release to not use the workaround if/when this PR gets released, but will probably just leave the jest 28 implementation alone.

thebanjomatic commented 2 years ago

@lmiller1990 Have you had the chance to look at this PR?

lmiller1990 commented 2 years ago

@thebanjomatic I was offline for all of Oct. I'm back now, let me take a look.

thebanjomatic commented 2 years ago

Thanks @lmiller1990 I have updated this PR with your suggested changes. I'm no longer personally in need of the jest 28 release unless you'd just prefer to patch it because it was broken in v28.1.0

lmiller1990 commented 2 years ago

Done https://github.com/vuejs/vue-jest/releases/tag/v29.2.0

LMK if you have any issues.