search

vuejs / vue-jest

Jest Vue transformer
MIT License
742 stars 159 forks source link

docs: Jest globals key is always `vue-jest` #519

Closed hngl closed 5 months ago

hngl commented 1 year ago

The key used to get config is vue-jest in both @vue/vue2-jest and @vue/vue3-jest, not the respective Vue/Jest version dependent package variant name.

https://github.com/vuejs/vue-jest/blob/3dc76ff8491d149d89a8ba5deb02f517f1535f98/packages/vue2-jest/lib/utils.js#L57

https://github.com/vuejs/vue-jest/blob/3dc76ff8491d149d89a8ba5deb02f517f1535f98/packages/vue3-jest/lib/utils.js#L57

hngl commented 1 year ago

Hi! This is my first time contributing here. Thanks for you consideration.

hngl commented 5 months ago

@lmiller1990 Would you consider merging this?

lmiller1990 commented 5 months ago

Sure! Sorry about the delay.