search

vuejs / vue-jest

Jest Vue transformer
MIT License
748 stars 156 forks source link

fix: `lang='tsx'` doesn't work for Vue 3 SFC #547

Closed sevilyilmaz closed 1 year ago

sevilyilmaz commented 1 year ago

Applies the same fix that is added for Vue 2 with this PR: #395

Resolves #510

sevilyilmaz commented 1 year ago

@lmiller1990 @cexbrayat could you check this PR? (Pinging you as I'm not sure if you already got a notification or not)

cexbrayat commented 1 year ago

LGTM (but I no longer actively maintain this as we switched to vitest to run our tests)

sevilyilmaz commented 1 year ago

I understand the reasoning.

It would be great to have PRs for bug fixes reviewed and released. Because it’s not straightforward to switch to vitest especially in big monorepos

lmiller1990 commented 1 year ago

I too do not really use / maintain this, but I will review and release your fix, give me until the end of the week (5th or 6th of Aug).

We really need someone who is actively invested in this repo, for now I'm happy to do the minimum of review / release patches, but I only check when someone pings me.

lmiller1990 commented 1 year ago

@sevilyilmaz done: https://github.com/vuejs/vue-jest/releases/tag/v29.2.5

sevilyilmaz commented 1 year ago

@lmiller1990 thank you!