search

vuejs / vue-loader

📦 Webpack loader for Vue.js components
MIT License
4.99k stars 914 forks source link

add vue 3.2.13+ as peer dependency #1944

Closed cool-little-fish closed 1 year ago

cool-little-fish commented 2 years ago

Hi @yyx990803 , I find that vue/compiler-sfc was required explicitly in vue-loader 17+ in line, but when I install vue-loader separately, it did not give me note that vue 3.2.13+ was required (cuz after vue 3.2.13+, @vue/compiler-sfc was installed with it, so compiler-sfc module can be imported with name vue/compiler-sfc). So I make this pr, hope that others won't get same problem.

merceyz commented 2 years ago

It's also missing an optional peer dependency on @vue/compiler-sfc which was removed as a peer dependency in https://github.com/vuejs/vue-loader/commit/21725a4ebc9c8d7f8a590d700017759327e21c2e even though it's still in use https://github.com/vuejs/vue-loader/blob/6a293dff5f2ed3167eb3b448f1d714091185a44e/src/compiler.ts#L18.

haoqunjiang commented 1 year ago

Sorry that I have overlooked this repo for a long time. Didn't know this issue even got into Yarn's compatibility database 🤦‍♂️ Now fixed in v17.0.1.