search

vuejs / vue

This is the repo for Vue 2. For Vue 3, go to https://github.com/vuejs/core
http://v2.vuejs.org
MIT License
207.38k stars 33.63k forks source link

Vue 2.x reactivity broken when using nested named slots with the same name #12245

Open enekesabel opened 2 years ago

enekesabel commented 2 years ago

Version

2.6.11

Reproduction link

codesandbox.io

Steps to reproduce

Click the "increment" button

What is expected?

the counter in the #default slot of the Parent should increment as well, when pressing the button

What is actually happening?

the counter in the #default slot of the Parent does not update

I have a Parent component, which has a default slot, and I'd like to display some stuff in the default slot of that component. The Parent component contains two child components both of them have a named slot called "content". These child components are nested in the Parent, the first renders the second in its #content slot, and the second renders the Parent's #default slot in its #content slot.

Observation: The reactivity inside the Parent's default slot is broken as long as the two nested child components' slot names match. (If we reused one of the WithContentSlot components twice, it would give the same result).

In my real project I'm working with a bunch of renderless components which expose some of their logic via slotProps on their #default slot, if I nest any of them, then I run into this issue.

JuniorTour commented 2 years ago

This issue seems to be relate to https://github.com/vuejs/vue/issues/12232.

Both of them use named nested scoped slot.

liyongning commented 2 years ago

This appears to be a bug with the v-slot instruction shorthand (#xx), which can be fixed using slot= "xx" syntax，i.e: <template #content></template> changed to <template slot="content"></template>

Sporradik commented 12 months ago

We ran into this recently. Thank you for the suggestion @liyongning!

We are using different names and it still doesn't work with the # syntax