vuejs / vuefire

🔥 Firebase bindings for Vue.js
https://vuefire.vuejs.org
MIT License
3.82k stars 323 forks source link

chore: allow `firebase-admin` v12 #1473

Closed luc122c closed 6 months ago

luc122c commented 6 months ago

The Firebase Admin SDK for Node has been bumped to v12. This currently leads to unmet peer dependency warnings:

 WARN  Issues with peer dependencies found
 
└─┬ nuxt-vuefire 1.0.0
  └── ✕ unmet peer firebase-admin@^11.3.0: found 12.0.0

This PR adds v12 to the allowed ranges.

posva commented 6 months ago

Thanks! It looks like firebase-functions are still not supporting firebase-admin 12, so we will have to wait a bit longer. I pushed changes to actually change the peer dep (it wasn't changed)

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1e2c71e) 75.93% compared to head (96a6de4) 75.93%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1473 +/- ## ======================================= Coverage 75.93% 75.93% ======================================= Files 21 21 Lines 3387 3387 Branches 263 263 ======================================= Hits 2572 2572 Misses 815 815 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

luc122c commented 6 months ago

I pushed changes to actually change the peer dep (it wasn't changed)

Oops, missed that! Thanks :)

luc122c commented 6 months ago

Thanks! It looks like firebase-functions are still not supporting firebase-admin 12, so we will have to wait a bit longer.

It looks like there is a PR tracking this: https://github.com/firebase/firebase-functions/issues/1496

posva commented 6 months ago

Thanks for the PR. I will locally update once the upstream issue is fixed.

prvashisht commented 4 months ago

@posva it was merged a few hours after you closed this :D any update on this fix?

luc122c commented 2 weeks ago

@posva Is there any chance this could be looked at again please?