search

vuejs / vuefire

🔥 Firebase bindings for Vue.js
https://vuefire.vuejs.org
MIT License
3.82k stars 323 forks source link

ssrKey: false not working in useDocument #1504

Closed daviddomkar closed 3 months ago

daviddomkar commented 3 months ago

Reproduction

Just set ssrKey to false - it will type warn and also still call onServerPrefetch

Steps to reproduce the bug

Just set ssrKey to false - it will type warn and also still call onServerPrefetch

Expected behavior

I would expect setting ssrKey to false disables onServerPrefetch and have correct typings.

Actual behavior

setting ssrKey to false type warns and also still calls onServerPrefetch

Additional information

I followed the documentation here: https://vuefire.vuejs.org/guide/ssr.html#Exclude-from-hydration from the behavior and the code in this repo it seems that the feature is not yet implemented?

posva commented 3 months ago

It's not implemented yet so in the meantime, I removed it from docs. If you want to implement it, feel free to submit a PR though