vuejs / vuepress

📝 Minimalistic Vue-powered static site generator
https://vuepress.vuejs.org
MIT License
22.5k stars 4.77k forks source link

start with underscore path, github pages doesn't accept #1134

Open mAKEkr opened 5 years ago

mAKEkr commented 5 years ago

Bug report

Version

1.0.0-alpha.27

Steps to reproduce

  1. using blog plugin
  2. make markdown file called 2018-12-16-review.md
  3. run vuepress build source

What is expected?

comile on path into 2018-12-16-review/index.html

What is actually happening?

compiled path to _2018-12-16-review/index.html

Other relevant information

github pages accepted jekyll static page builder rules, ignore started with _ folders. stackoverflow

i think code structure change of shared-utils/slugify solve this issue.

if code has changed, it is maybe cause critical issue.

ulivz commented 5 years ago

Could you provide a minimal reproduction repo?

mAKEkr commented 5 years ago

https://github.com/mAKEkr/vuepress-issue-example-1134 this is reproduction repository.

I have implemented this issue on my blog, and when I click on the latest post on my blog, it works normally by the js that I called in, but it is not connected when I connect directly to the URL.

aspiers commented 3 years ago

@mAKEkr commented on December 25, 2018 11:29 AM:

i think code structure change of shared-utils/slugify solve this issue.

I don't see how slugify relates to this at all? That's for generation of header anchors.

aspiers commented 3 years ago

Ah sorry, I guess maybe slugify is used for generation of file paths, not just header anchors?