search

vuematerial / vue-material

Vue.js Framework - ready-to-use Vue components with Material Design, free forever.
https://www.creative-tim.com/vuematerial
MIT License
9.89k stars 1.15k forks source link

Spacing standards #1533

Open bentatum opened 6 years ago

bentatum commented 6 years ago

Is there a standard way to apply spacing values?

For instance, in React's material-ui implementation, there is a spacing.unit value that you can feed the theme upon instantiation and later used in styles.

margin-right: $spacing-unit

or

class="md-spacing-1"

Is there something like that in this library?

VdustR commented 6 years ago

space for MdLayout?

bentatum commented 6 years ago

I noticed that here. https://github.com/vuematerial/vue-material/blob/dev/src/components/MdLayout/variables.scss

Mystery solved if the rest if all components referenced these values. Doesn't appear to be the case.

:/

I can contribute a PR if contributors think something like this would make sense.

VdustR commented 6 years ago

That value is from material design (Margins and Gutters). It's only for MdLayout.

bentatum commented 6 years ago

thanks @VdustR I realize that.

I think this library would benefit from having some standard way of handling spacing values.

For example, take a look at how the leading implementation of material-ui for React does it.

Is this on the road map @marcosmoura? I'd be happy to contribute if you agree.