search

vuematerial / vue-material

Vue.js Framework - ready-to-use Vue components with Material Design, free forever.
https://www.creative-tim.com/vuematerial
MIT License
9.88k stars 1.16k forks source link

MdSelect - Add reference to correct DOM element #2288

Closed hansvn closed 3 years ago

hansvn commented 3 years ago

Bugfix for #2285: When a value is selected in MdSelect it tries to get the DOM elements ($el) validy property. While this works for MdInput, which has an <input> element as its root DOM element; MdSelects $el is a <md-menu> which doesn't have the validity property.

This bugfix adds a reference to the correct DOM element when checking for the select input validity. It overrides the mixins isInvalidValue method with a reference to the correct DOM <select> element (which has the required validity property defined).

Tropicalista commented 3 years ago

Please can you merge this?

mrkoshi commented 3 years ago

How long we will wait for this merge? Is there some problems with it?

Tropicalista commented 3 years ago

@mrkoshi I think in dev branch is merged. However this library seems abandoned...

OladetounJed commented 3 years ago

@hansvn , when will the NPM package be updated?

We are still having similar issues with the package