vuepress-theme-hope / vuepress-theme-hope

A vuepress theme with tons of features✨
https://theme-hope.vuejs.press
MIT License
1.97k stars 697 forks source link

[Feature Request] Don’t publish when demo deploy failed #2914

Closed DreamOfIce closed 1 year ago

DreamOfIce commented 1 year ago

Checklist

Describe the feature

目前经常遇到某个新版本完全无法使用,能不能让CI在发布前先测试一下,或者把那些demo和文档的部署作为测试? 后者的话可以通过将publish.yml的触发条件改为依赖release.yml实现:https://docs.github.com/zh/actions/using-workflows/events-that-trigger-workflows#running-a-workflow-based-on-the-conclusion-of-another-workflow 没问题的话我愿意去写个pr

Additional context

No response

Mister-Hope commented 1 year ago

目前经常遇到某个新版本完全无法使用

比如?

DreamOfIce commented 1 year ago

目前经常遇到某个新版本完全无法使用

比如?

https://github.com/vuepress-theme-hope/vuepress-theme-hope/issues/2874 https://github.com/vuepress-theme-hope/vuepress-theme-hope/issues/2847 https://github.com/vuepress-theme-hope/vuepress-theme-hope/issues/2886

DreamOfIce commented 1 year ago

@Mister-Hope ?不同意的话我就先关掉issue了

Mister-Hope commented 1 year ago

你提pr吧,我是觉得没必要,至少你举的例子里有一个就不影响ci

Mister-Hope commented 1 year ago

Any update?

Mister-Hope commented 1 year ago

Supported with: https://github.com/vuepress-theme-hope/vuepress-theme-hope/commit/928c1ded9dfc421c85504332e627d5a9a36c5ee9

Waste a lot of my time

https://github.com/vuepress-theme-hope/vuepress-theme-hope/actions/runs/4508891355

image