[Bug]

[HuberTRoy]

Checklist

• [X] I am using LTS version of Node.js.
• [X] I am using the latest v2 version of VuePress and VuePress official plugins.
• [X] I am using the latest v2 version of vuepress-theme-hope and all plugins in this repo.
• [X] I followed the docs and I double checked my configuration.
• [X] I have searched FAQ and I did not find the answer.

Package name

vuepress-theme-hope

Which operating system are you using?

• [X] macOS
• [X] Windows
• [X] Linux

Describe the bug

https://github.com/vuepress-theme-hope/vuepress-theme-hope/blob/4df6e344f7c3651f46b9097e47fbc096a53244dd/packages/theme/templates/index.build.html#L15

The template on prod hardcode the background.

The configuration background on palette.scss not working fully.

Additional context

No response

[Mister-Hope]

Have you ever test that? Normally, body is on html and sharing the same size, so the bgcolor will be applied correctly.

[github-actions[bot]]

Hello @HuberTRoy. Please provide a minimal reproduction using a GitHub repository or vuepress-theme-hope.github.io/v2-new. Issues marked with needs reproduction will be closed if they have no activity within 3 days.

[Mister-Hope]

Try not waste others time

[github-actions[bot]]

Hello @HuberTRoy. This issue is marked as invalid and closed. Please make sure you are reporting an issue and following the issue template.

[HuberTRoy]

@Mister-Hope Sorry for waste your time.

Please see https://github.com/subquery/documentation, check out on 0f9042f4f5a1941df508814a09281e0aa2cd90bc.

Build and serve it.

The config is darkmode only and have configaration with

$bg-color: (
  light: #060f32,
  dark: #060f32,
);

I don't find relative changes on the new version change log. If it has been change.

[HuberTRoy]

The key I think is only compile palette.scss as :root and the hardcode is

      html[data-theme="dark"] {
        --bg-color: #1d1e1f;
      }

      html,
      body {
        background: var(--bg-color);
      }

The priority of html[data-theme="dark"] greater than :root, so var(--bg-color) is hardcode not custom.

[Mister-Hope]

Hi like I said above, the final color displayed should be body’s bgcolor

[Mister-Hope]

I am not sure, as you are already applying a patch.

Just take our theme docs as an example:

The body background color comes from css file:

While the color defined in template is already overrided:

Create a new template and try modifying $bg-color, everthing should work as expected.

I am curious why you need an !important